Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cell-out-of-bounds crashes in BuildableTerrainLayer. #15924

Merged
merged 1 commit into from Dec 22, 2018
Merged

Fix cell-out-of-bounds crashes in BuildableTerrainLayer. #15924

merged 1 commit into from Dec 22, 2018

Conversation

pchote
Copy link
Member

@pchote pchote commented Dec 21, 2018

Fixes #15916.

@pchote pchote added this to the Next Release milestone Dec 21, 2018
obrakmann
obrakmann approved these changes Dec 21, 2018
View reviewed changes
Copy link
Contributor

@obrakmann obrakmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately I haven't been able to reproduce the crash, but this does make sense. 👍

@reaperrr reaperrr merged commit 5efbcf1 into OpenRA:bleed Dec 22, 2018
@reaperrr
Copy link
Contributor

https://github.com/OpenRA/OpenRA/wiki/Changelog-(bleed)/_compare/c31b5f223babc51c24ef53737c502056f605f3c3...81f4d08c1ba95d786b9f31db9965d2a5797b0488

@pchote pchote deleted the fix-concrete-crash branch January 26, 2019 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reaperrr reaperrr reaperrr approved these changes

@obrakmann obrakmann obrakmann approved these changes

Assignees
No one assigned
Labels
PR: Needs +2
Projects
None yet
Milestone
Release 20190314
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchote @reaperrr @obrakmann